Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dva@2 #1119

Merged
merged 10 commits into from
Aug 31, 2017
Merged

dva@2 #1119

merged 10 commits into from
Aug 31, 2017

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Aug 9, 2017

Close #772

@nihgwu
Copy link
Member

nihgwu commented Aug 9, 2017

我还是觉得 dva-react 不应该包括 router，而是在 dva 里包括，现在这里 dva 跟 dva-react 的区别跟定位分别是什么？

@sorrycc
Copy link
Member Author

sorrycc commented Aug 9, 2017

  • dva 基于 react-router@4
  • dva-react 基于 react-router@3，给老版本用户无痛升级用的

@nihgwu
Copy link
Member

nihgwu commented Aug 9, 2017

👍

@nihgwu
Copy link
Member

nihgwu commented Aug 9, 2017 •
edited
Loading

其实 对于使用 react-router@3 的用户继续用 dva@1 就行，没必要提供两个不同名字但是功能相同只是版本不同的库

@sorrycc
Copy link
Member Author

sorrycc commented Aug 9, 2017

需要考虑公司内部百来个项目的升级问题，不能就不管他们了。。

@nihgwu
Copy link
Member

nihgwu commented Aug 9, 2017

好吧，那我之前在dva-core提的建议呢，我觉得dva应该内部避免重复注册的问题，我记得这个在dva1的时候就有这个问题

@sorrycc
Copy link
Member Author

sorrycc commented Aug 9, 2017 •
edited
Loading

现在的 model 就是不允许重复注册的吧。

@Tsury
Copy link

Tsury commented Aug 17, 2017

Will this PR add support for React 16?

@sorrycc sorrycc mentioned this pull request Aug 18, 2017
Closed
kenan2002
kenan2002 reviewed Aug 19, 2017
View reviewed changes
packages/dva/README.md Outdated
[![NPM downloads](http://img.shields.io/npm/dm/dva-react.svg?style=flat)](https://npmjs.org/package/dva-react)
[![Dependencies](https://david-dm.org/dvajs/dva-react/status.svg)](https://david-dm.org/dvajs/dva-react)

Official React bindings for dva, with react-router2.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是 with react-router@4 吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的。

@sorrycc sorrycc mentioned this pull request Aug 30, 2017
Closed
sorrycc added 3 commits August 31, 2017 08:12
@sorrycc
update docs
816e8f4
@sorrycc
docs: update
2c9fae3
@sorrycc
publish
efe69e4 
- dva@2.0.0-rc.1
- dva-core@0.2.0
- dva-react@0.2.0
@sorrycc sorrycc merged commit efe69e4 into master Aug 31, 2017
@sorrycc sorrycc deleted the 2.0 branch August 31, 2017 09:07
@afc163 afc163 mentioned this pull request Aug 31, 2017
Closed
@ouzhou
Copy link

ouzhou commented Sep 4, 2017

是否打算使用async await?

@afc163
Copy link
Contributor

afc163 commented Sep 6, 2017

@sorrycc https://ant.design/docs/react/practical-projects-cn 这个文档是否需要更新到 2.0？

@sorrycc
Copy link
Member Author

sorrycc commented Sep 6, 2017

@afc163 我今天更新下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenan2002 kenan2002 kenan2002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sorrycc @nihgwu @Tsury @ouzhou @afc163 @kenan2002